Conversation
Key Previous/Next aria labels off isAtStart/isAtEnd instead of the presence of an item title, so a middle item with an empty title still announces its position. When looping (_canCycleThroughPagination), isAtStart/isAtEnd are forced false since the buttons never disable and always wrap. Aligns with adapt-contrib-narrative. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…315) Update the popup previous/next aria-label globals from the old title-keyed default to the new isAtStart/isAtEnd default, but only when the value still equals the old default so author customizations are kept. Uses @@CURRENT_VERSION/@@RELEASE_VERSION placeholders. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kirsty-hames
approved these changes
Jul 1, 2026
kirsty-hames
left a comment
kirsty-hames
left a comment
Contributor
There was a problem hiding this comment.
Works as expected thanks @swashbuck - tested with voiceOver Safari on Mac 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #315
Update
isAtStart/isAtEndinstead of the presence of an item title. So a middle item with an empty title still announces its position (e.g. "Previous (item 2 of 3)") instead of falling back to a bare "Previous"/"Next"._canCycleThroughPagination),isAtStart/isAtEndare forcedfalse. The buttons never disable and always wrap, so the active item is never treated as the start or end and the item count is always announced.previous/nextglobals on existing courses, but only where the value still equals the old default. Author customizations are preserved.Testing
title: Previous/Next still announce "(item N of M)" rather than the bare label._canCycleThroughPagination: buttons never disable, wrap correctly, and always announce the item count (including at the first/last item).grunt migration:testpasses (28/28).Posted via collaboration with Claude Code