Conversation
ethan-lp
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184
Fix
_canShowModelAnswermust betrue.Visible thumb after submission: The slider thumb now stays visible after a correct submit (marks the learner's pick). It is hidden only during the "show correct answer" view for an incorrect submission.
is-disabledkeepscursor: defaultto signal the control is non-interactive.Fill bar issue: Fixed the fill bar during "show correct answer": it now spans the actual correct range instead of running from the scale start to the range midpoint. Previously a 5-9 range highlighted 5-9 but filled 1-7, which was misleading.
Previous:

Fixed:

show-correct-answerclass whenever the correct range is shown (including on a correct submit), so the existing Vanilla theme rules colour the range circles and fill with the validation/success colour. No companion theme change required. The thumb-hide rule was scoped to.show-correct-answer.is-incorrectso the thumb stays visible on a correct submit.Testing
_correctRange(e.g._bottom: 5,_top: 9) and_canShowModelAnswer: true.Companion issue to create
Hiding the handle in Confidence Slider -
adapt-contrib-confidenceSliderextendsSliderViewand reuses the sameslider__widget/slider__itemmarkup, so it shares slider's compiled thumb CSS. Because confidenceSlider never appliesshow-correct-answer, the changes here leave its handle visible after submit (it was previously hidden). If we want to retain the previous behaviour, confidenceSlider should add its own thumb-hide rule or be updated to decouple from slider's.show-correct-answergating.After submit:

Posted via collaboration with Claude Code