Skip to content

Chore: Document _styleBeforeCompletion and _styleAfterClick (fixes #260) - #261

Merged
swashbuck merged 2 commits into
masterfrom
issue/260
May 27, 2026
Merged

Chore: Document _styleBeforeCompletion and _styleAfterClick (fixes #260)#261
swashbuck merged 2 commits into
masterfrom
issue/260

Conversation

@swashbuck

@swashbuck swashbuck commented May 22, 2026

Copy link
Copy Markdown
Contributor

Fixes #260

Update

  • README: add note to _styleAfterClick clarifying that _isFullWidth: true force-hides the button after completion regardless of _styleAfterClick (TrickleButtonModel.js:195).
  • properties.schema: expand help text for _styleBeforeCompletion and _styleAfterClick to include defaults and the _isFullWidth interaction (both occurrences: article + block).
  • schema/article.schema.json and schema/block.schema.json: add description field for both properties (previously absent).

Testing

  1. Open README and confirm note on _styleAfterClick mentions _isFullWidth override.
  2. In an authoring tool, edit Trickle config on an article or block and hover the Visibility before/after completion fields. Tooltips should show the new help text including defaults and the Full Width caveat.

Posted via collaboration with Claude Code

@swashbuck swashbuck changed the title Chore: Document _isFullWidth override of _styleAfterClick (fixes #260) Update: Document _styleBeforeCompletion and _styleAfterClick (fixes #260) May 22, 2026

@kirsty-hames kirsty-hames left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described thanks @swashbuck 👍

@swashbuck swashbuck changed the title Update: Document _styleBeforeCompletion and _styleAfterClick (fixes #260) Chore: Document _styleBeforeCompletion and _styleAfterClick (fixes #260) May 26, 2026
@swashbuck
swashbuck merged commit e835a7f into master May 27, 2026
@swashbuck
swashbuck deleted the issue/260 branch May 27, 2026 15:55
@github-project-automation github-project-automation Bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Recently Released

Development

Successfully merging this pull request may close these issues.

Document _styleBeforeCompletion and _styleAfterClick (README + schemas)

3 participants