fix: connect and disconnect room issues

adarshaacharya · Oct 13, 2021 · 5736eb0 · 5736eb0
1 parent b5a93bb
commit 5736eb0
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 6 deletions.
diff --git a/client/src/_context/room/room.state.tsx b/client/src/_context/room/room.state.tsx
@@ -42,6 +42,7 @@ const RoomState: React.FC = ({ children }) => {
                     payload: room,
                 });
                 history.push(`/room/${room._id}`);
+                message.success('New room created ! 🔥 ');
             });
             setRoomUser(username); // set username in state
         } catch (error) {

diff --git a/client/src/components/CreateRoom/CreateRoom.tsx b/client/src/components/CreateRoom/CreateRoom.tsx
@@ -20,8 +20,8 @@ const CreateRoom = () => {
 
     const onFormSubmit = (values: IVal) => {
         createRoom(values);
-        playIpl();
-        message.success('New room created ! 🔥 ');
+        // playIpl();
+        // message.success('New room created ! 🔥 ');
     };
 
     const [form] = Form.useForm();

diff --git a/client/src/constants/sockets.ts b/client/src/constants/sockets.ts
@@ -1,7 +1,7 @@
 export const SOCKETS_EVENT = `socket.event`;
 
-export const SOCKETS_EVENT_CONNECTED = `${SOCKETS_EVENT}.connection`;
-export const SOCKETS_EVENT_DISCONNECTED = `${SOCKETS_EVENT}.disconnect`;
+export const SOCKETS_EVENT_CONNECTED = `connect`;
+export const SOCKETS_EVENT_DISCONNECTED = `disconnect`;
 export const SOCKETS_EVENT_CONNECTION_ERROR = `${SOCKETS_EVENT}.connection.error`;
 
 export const SOCKETS_EVENT_USER_JOINED = `${SOCKETS_EVENT}.join.room`;

diff --git a/server/constants/sockets.ts b/server/constants/sockets.ts
@@ -1,7 +1,7 @@
 export const SOCKETS_EVENT = `socket.event`;
 
-export const SOCKETS_EVENT_CONNECTED = `${SOCKETS_EVENT}.connection`;
-export const SOCKETS_EVENT_DISCONNECTED = `${SOCKETS_EVENT}.disconnect`;
+export const SOCKETS_EVENT_CONNECTED = `connection`;
+export const SOCKETS_EVENT_DISCONNECTED = `disconnect`;
 export const SOCKETS_EVENT_CONNECTION_ERROR = `${SOCKETS_EVENT}.connection.error`;
 
 export const SOCKETS_EVENT_USER_JOINED = `${SOCKETS_EVENT}.join.room`;

diff --git a/server/controllers/room.controller.ts b/server/controllers/room.controller.ts
@@ -156,6 +156,7 @@ const socketio = (server: Server) => {
 
                 io.to(roomID).emit(SOCKETS_EVENTS_UPDATE_OUTPUT, output.data);
             } catch (error) {
+                // @ts-ignore
                 console.log(error.message);
             }
         });