Remove lineHeight and use align-content to vertically align items
#3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3415 +/- ##
==========================================
- Coverage 98.21% 98.17% -0.05%
==========================================
Files 47 47
Lines 5098 5083 -15
Branches 723 719 -4
==========================================
- Hits 5007 4990 -17
- Misses 91 93 +2
|
nstepien
approved these changes
Jul 8, 2024
adityatoshniwal
pushed a commit
to pgadmin-org/react-data-grid
that referenced
this pull request
Jul 31, 2024
…adazzle#3415) * Remove lineHeight and use `align-content` to vertically align items * No need to animate line height * Fix tests * Fix treeview and master detail examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://twitter.com/yisibl/status/1734511505356525687
https://rachelandrew.co.uk/archives/2023/12/19/align-content-in-block-layout/
https://caniuse.com/mdn-css_properties_align-content_block_context
Works great
