Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and fix vulcan-trivy #784

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Improve and fix vulcan-trivy #784

merged 1 commit into from
Jan 17, 2025

Conversation

jesusfcr
Copy link
Contributor

@jesusfcr jesusfcr commented Jan 16, 2025

  • Uses a local logger
  • Fixes panic when trivy fails
  • Uses sdk helper/command
  • Prevent leaked directories/files
  • Skip big non-binary files when secret analysis is activated.
  • Other refactors.

@jesusfcr jesusfcr changed the title improve and fix vulcan-trivy Improve and fix vulcan-trivy Jan 16, 2025
Copy link
Contributor

@danfaizer danfaizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments and a couple of minor changes.
Thanks for taking a look and the improvements implemented.

cmd/vulcan-trivy/vulcan-trivy.go Outdated Show resolved Hide resolved
cmd/vulcan-trivy/vulcan-trivy.go Show resolved Hide resolved
cmd/vulcan-trivy/vulcan-trivy.go Outdated Show resolved Hide resolved
cmd/vulcan-trivy/vulcan-trivy.go Show resolved Hide resolved
@jesusfcr jesusfcr requested a review from danfaizer January 17, 2025 10:32
Copy link
Contributor

@danfaizer danfaizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusfcr jesusfcr merged commit f666ef9 into master Jan 17, 2025
2 checks passed
@jesusfcr jesusfcr deleted the improve-trivy branch January 17, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants