Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent overwrite of hidden relations in patch #9

Merged
merged 2 commits into from
Dec 27, 2023
Merged

fix: prevent overwrite of hidden relations in patch #9

merged 2 commits into from
Dec 27, 2023

Conversation

Yelinz
Copy link
Member

@Yelinz Yelinz commented Dec 20, 2023

Thanks for @anehx pointing this out and @open-dynaMIX suggesting a solution path.

@Yelinz Yelinz force-pushed the fix-relation-patch branch from 0f1b258 to 40e8fa0 Compare December 20, 2023 09:54
anehx
anehx reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some missing docs, otherwise LGTM!

generic_permissions/visibilities.py Outdated Show resolved Hide resolved
generic_permissions/visibilities.py Show resolved Hide resolved
@Yelinz Yelinz force-pushed the fix-relation-patch branch from 40e8fa0 to f36b0d6 Compare December 20, 2023 10:04
@Yelinz Yelinz marked this pull request as ready for review December 20, 2023 10:07
anehx
anehx previously approved these changes Dec 20, 2023
View reviewed changes
generic_permissions/visibilities.py Show resolved Hide resolved
generic_permissions/visibilities.py Outdated Show resolved Hide resolved
winged
winged requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some docs that I'd recommend adding, but also some validation to ensure people don't just accidentally use DGAP wrong and lose data

README.md Outdated Show resolved Hide resolved
generic_permissions/visibilities.py Show resolved Hide resolved
generic_permissions/visibilities.py Show resolved Hide resolved
@Yelinz Yelinz force-pushed the fix-relation-patch branch from f36b0d6 to f0fb9ee Compare December 20, 2023 14:44
@Yelinz Yelinz force-pushed the fix-relation-patch branch from f0fb9ee to 7247483 Compare December 20, 2023 14:48
winged
winged previously requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work cleaning that up! Just some last things noticed in my suggested code

generic_permissions/visibilities.py Outdated Show resolved Hide resolved
generic_permissions/visibilities.py Outdated Show resolved Hide resolved
generic_permissions/visibilities.py Outdated Show resolved Hide resolved
@anehx anehx dismissed winged’s stale review December 27, 2023 09:06

All addressed, vacation absence.

@anehx anehx merged commit 216fb80 into main Dec 27, 2023
16 checks passed
@anehx anehx deleted the fix-relation-patch branch December 27, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anehx anehx anehx approved these changes

@winged winged winged left review comments

@open-dynaMIX open-dynaMIX Awaiting requested review from open-dynaMIX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yelinz @winged @anehx