chore(API): refactor template upload #1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the refactoring of the build, the documented commands don't work anymore. Additionally the path to the templates changes now dynamically with the python version used. This commit puts all the templates into one global template directory. The command is refactored, so that it's sufficient to provide the file name. The path to the template will then be constructed in the command.
open-dynaMIX
force-pushed
the
refactor_template_upload
branch
from
73db40d to
13560b3
Compare
This commit refactors the `upload_template` command, so that is now uses positional arguments for templates and can handle multiple at once.
Yelinz
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the refactoring of the build, the documented commands don't work anymore. Additionally the path to the templates changes now dynamically with the python version used. This commit puts all the templates into one global template directory. The command is refactored, so that it's sufficient to provide the file name. The path to the template will then be constructed in the command.
More commits:
feat(API): allow for uploading multiple templates at once
This commit refactors the
upload_templatecommand, so that is now usespositional arguments for templates and can handle multiple at once.
chore: improve dev docs