fix(frontend/bulk-edit): unsaved changes warning for task when task not changed #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
velrest
approved these changes
Jan 7, 2025
…ot changed
this was caused by
```glimmer
{{#if
(and
f.model.change.task
(not (eq f.model.change.task.id model.task.id))
)
}}
<ChangedWarning />
{{/if}}
```
when the changeset is modified `f.model.change.task` will be set to an empty object, this satisfies the first condition as objects are always truthy:
```glimmer
{{#if
(and
{}
(not (eq f.model.change.task.id model.task.id))
)
}}
<ChangedWarning />
{{/if}}
```
when we now look at the values of `f.model.change.task.id` and `model.task.id`, we can see that:
`f.model.change.task.id` -> `undefined`
`model.task.id` -> `null`
`null` and `undefined` aren't the same, therefore:
`(not (eq f.model.change.task.id model.task.id))` -> `(not (eq undefined null))` -> `(not (false))` -> `true`
because of that, modifying another value of the changeset resulted in:
```glimmer
{{#if
(and
{}
true
)
}}
<ChangedWarning />
{{/if}}
```
c0rydoras
force-pushed
the
fix/frontend/bulk-edit/unsaved-changes-task
branch
from
64abf8b to
19fcfe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was caused by
when the changeset is modified
f.model.change.taskwill be set to an empty object, this satisfies the first condition as objects are always truthy:when we now look at the values of
f.model.change.task.idandmodel.task.id, we can see that:f.model.change.task.id->undefinedmodel.task.id->nullnullandundefinedaren't the same, therefore:(not (eq f.model.change.task.id model.task.id))->(not (eq undefined null))->(not (false))->truebecause of that, modifying another value of the changeset resulted in: