Add metrics for last committed watermarks #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauliusvl
force-pushed
the
commited-watermark-metric
branch
from
0a7806d to
3baeffd
Compare
sauliusvl
force-pushed
the
commited-watermark-metric
branch
from
3baeffd to
0e44015
Compare
shivam247
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the last consumed watermark is being exposed as a metric, which is not the full story, as it does not tell anything about the actual data freshness in the sink. Hence we add a new metric for tracking watermarks per partition that only gets updated when data actually gets sinked.
Also bumping all versions.