Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building tests on PPC #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barracuda156
Copy link
Contributor

Without this the build fails badly with multiple assembler errors:

{standard input}:66102:Invalid mnemonic 'brk'

With the patch, all tests pass:

--->  Testing arghandler
Executing:  cd "/opt/local/var/macports/build/_opt_PPCRosettaPorts_devel_arghandler/arghandler/work/build" && ./argh_tests 
[doctest] doctest version is "2.4.6"
[doctest] run with "--help" for options
===============================================================================
[doctest] test cases:  29 |  29 passed | 0 failed | 0 skipped
[doctest] assertions: 367 | 367 passed | 0 failed |
[doctest] Status: SUCCESS!

P. S. I had to rename the port, since we already have argh in Macports.

@adishavit
Copy link
Owner

Thanks for you PR!
doctest is a drop-in, header only, unit-testing framework.

I prefer not make changes (nor maintain) to its drop-in header file.

Maybe @onqtam or @Saalvage can comment on the change?

@barracuda156
Copy link
Contributor Author

barracuda156 commented Jan 16, 2023

@adishavit Well, it has a clearly wrong fallback code which breaks tests. But of course it is up to you :)

P. S. I will make a PR to upstream today, let it be fixed in general.

@barracuda156
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants