New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old keyword being used in module loaders #127

Open

bercowsky wants to merge 1 commit into aditya-grover:main from bercowsky:andres-keywordfix

bercowsky commented Dec 27, 2024

There is a bug in the keywords from cl.load_model_module introduced here, by renaming the keyword from preset to architecture.

Under /experiments and /notebooks, the old keyword is still being used. For example:

climatology = cl.load_forecasting_module(data_module=dm, preset="climatology")

found in experiments/forecasting/era5_era5_baselines.py


          Fix old keyword being used in module loaders

b35bb82

bercowsky requested a review from tung-nd as a code owner

December 27, 2024 11:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet