Merged
Conversation
rossbrandon
reviewed
Oct 10, 2025
transformers/product.js
Outdated
| * @param {{ id: string; name: string; quantity: number }[]} bundledProducts - Array of bundled product objects | ||
| * @returns {object[]} Array of bundle group objects for ACO | ||
| */ | ||
| function buildAcoBundles(bundledProducts) { |
Contributor
There was a problem hiding this comment.
Nit: use const arrow functions instead of the function syntax. Right now this file has a mix of both and we should standardize.
Contributor
Author
There was a problem hiding this comment.
Standarized to const
|
|
||
| /** | ||
| * Transforms a Salesforce product to an ACO product. | ||
| * Builds the bundles array for an ACO parent bundle product. |
Contributor
There was a problem hiding this comment.
It looks like the comment for transformProduct was removed during this update. Can you add it back?
transformers/product.js
Outdated
| } | ||
|
|
||
| // Handle parent bundle product (type BUNDLE) using correct bundles array structure | ||
| if (product.type === 'BUNDLE' && Array.isArray(product.bundledProducts) && product.bundledProducts.length > 0) { |
Contributor
There was a problem hiding this comment.
Nit: you can just do this:
if (product.type === 'BUNDLE' && product.bundledProducts?.length)
rossbrandon
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.