Closed
Conversation
rossbrandon
force-pushed
the
usf-3785-aco-pdp-support
branch
from
9b93edd to
b3655ca
Compare
keoko
reviewed
Mar 10, 2026
sirugh
reviewed
Mar 10, 2026
sirugh
reviewed
Mar 10, 2026
sirugh
reviewed
Mar 10, 2026
sirugh
reviewed
Mar 10, 2026
sirugh
reviewed
Mar 10, 2026
keoko
reviewed
Mar 11, 2026
actions/fetch-all-products/aco.js
Outdated
| const { requestSaaS } = require("../utils"); | ||
| const { ProductsQuery } = require("../queries"); | ||
|
|
||
| // Limiting at 10,000 products per category |
Collaborator
There was a problem hiding this comment.
I think this is not applicable for the ACO implementation.
Suggested change
| // Limiting at 10,000 products per category |
Collaborator
Author
There was a problem hiding this comment.
It is applicable to ACO as well. It's a Catalog Service limitation on pagination (500 products per page, max 20 pages). I am reworking this logic to account for category paths related to the configured category families so we can get around this, though.
I think I'll just close this PR and open a new one with the reworked functionality.
actions/fetch-all-products/aco.js
Outdated
| let maxPage = productsResp.data.productSearch.page_info.total_pages; | ||
|
|
||
| if (maxPage > MAX_PAGES_FETCHED) { | ||
| console.warn(`Catalog has more than 10000 products.`); |
Collaborator
There was a problem hiding this comment.
Wouldn't it be better to make the error message more generic. Otherwise, any change on the pageSize or the MAX_PAGES_FETCHED would the error message be misleading.
Suggested change
| console.warn(`Catalog has more than 10000 products.`); | |
| console.warn(`Catalog has more products than the maximum supported. Only the first ${MAX_PAGES_FETCHED} pages will be fetched.`); |
Collaborator
Author
|
Closed in favor of #265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add PDP pre-rendering support for Commerce Optimizer (ACO) sites.
Ticket USF-3785
Changes
config['adobe-commerce-optimizer']orconfig.headers.cshas headers with theAC-prefix.categoriesfield toProductsQueryproduct.jsonstate file for use with future PLP pre-rendering.fetch-all-products/accs.jsandfetch-all-products/aco.jsfiles.