Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22 Add AuthorVH #136

Merged
merged 4 commits into from
Aug 17, 2020
Merged

#22 Add AuthorVH #136

merged 4 commits into from
Aug 17, 2020

Conversation

chrischrischris
Copy link
Contributor

Note that once flex is complete (#24) the FLEX_CLASS and FLEX_CONTAINER_SELECTOR consts may need to be updated.

Description

When CSS vertical height is set in authoring view, there is a bug where the editor.html will start an infinite scroll.

Adds a utility that watches for a vertical height change and applies the correct height as a pixel value instead of vh.

Related Issue

#24

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note that once flex is complete (adobe#24) the `FLEX_CLASS` and `FLEX_CONTAINER_SELECTOR` consts may need to be updated.
@auniverseaway auniverseaway merged commit 50d3899 into adobe:master Aug 17, 2020
@chrischrischris chrischrischris deleted the author_vh_22 branch November 6, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants