Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SITES-29275: use rel. references in scss to work with parcel sass 2.7+ #109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SITES-29275: use rel. references in scss to work with parcel sass 2.7+ #109

wants to merge 1 commit into from

Conversation

buuhuu
Copy link

@buuhuu buuhuu commented Mar 3, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@buuhuu buuhuu requested a review from bpauli March 3, 2025 16:28
bpauli
bpauli approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@bpauli bpauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with node v20.18.3 and v22.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpauli bpauli bpauli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buuhuu @bpauli