Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenu: remove UNSTABLE_ prefix from Submenu hooks #6283

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

reidbarber
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Apr 29, 2024

@rspbot
Copy link

rspbot commented Apr 29, 2024

@rspbot
Copy link

rspbot commented Apr 29, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@react-aria/menu

UNSTABLE_useSubmenuTrigger

-UNSTABLE_useSubmenuTrigger<T> {
-  props: AriaSubmenuTriggerProps
-  state: SubmenuTriggerState
-  ref: RefObject<FocusableElement>
-  returnVal: undefined
-}
+

useSubmenuTrigger

-
+useSubmenuTrigger<T> {
+  props: AriaSubmenuTriggerProps
+  state: SubmenuTriggerState
+  ref: RefObject<FocusableElement>
+  returnVal: undefined
+}

@react-stately/menu

UNSTABLE_useSubmenuTriggerState

-UNSTABLE_useSubmenuTriggerState {
-  props: SubmenuTriggerProps
-  state: RootMenuTriggerState
-  returnVal: undefined
-}
+

RootMenuTriggerState

 RootMenuTriggerState {
-  UNSTABLE_closeSubmenu: (Key, number) => void
-  UNSTABLE_expandedKeysStack: Array<Key>
-  UNSTABLE_openSubmenu: (Key, number) => void
   close: () => void
+  closeSubmenu: (Key, number) => void
+  expandedKeysStack: Array<Key>
   focusStrategy: FocusStrategy
   open: (FocusStrategy | null) => void
+  openSubmenu: (Key, number) => void
   toggle: (FocusStrategy | null) => void
 }

it changed:

  • useMenuTriggerState

useSubmenuTriggerState

-
+useSubmenuTriggerState {
+  props: SubmenuTriggerProps
+  state: RootMenuTriggerState
+  returnVal: undefined
+}

@reidbarber reidbarber merged commit 3f6ed62 into main Apr 29, 2024
25 checks passed
@reidbarber reidbarber deleted the submenu-remove-unstable branch April 29, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants