Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix πŸ› : Cross-Platform Path Resolution for empty.js in Locales Plugin #7568

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Jan 6, 2025

Closes #7462

βœ… Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

πŸ“ Test Instructions:

🧒 Your Project:

@ohansFavour ohansFavour changed the title Use absolute path resolution for empty.js fix: Use absolute path resolution for empty.js Jan 6, 2025
@ohansFavour ohansFavour changed the title fix: Use absolute path resolution for empty.js fix: Use absolute path resolution for empty.js in locales plugin Jan 6, 2025
@reidbarber
Copy link
Member

Thanks for the PR! If you sign the CLA, then close and re-open this to trigger a rebuild, the build should pass.

@ohansFavour ohansFavour closed this Jan 7, 2025
@ohansFavour ohansFavour reopened this Jan 7, 2025
@devongovett devongovett added release small review Easy to review PR labels Jan 7, 2025
@yihuiliao yihuiliao added this pull request to the merge queue Jan 8, 2025
Merged via the queue into adobe:main with commit e7053dd Jan 8, 2025
30 checks passed
@ohansFavour ohansFavour changed the title fix: Use absolute path resolution for empty.js in locales plugin Fix πŸ› : Seamless Cross-Platform Path Resolution in Locales Plugin Jan 10, 2025
@ohansFavour ohansFavour changed the title Fix πŸ› : Seamless Cross-Platform Path Resolution in Locales Plugin Fix πŸ› : Cross-Platform Path Resolution for empty.js in Locales Plugin Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release small review Easy to review PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@react-aria/optimize-locales-plugin does not work on Windows
4 participants