Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve verdaccio pipeline #7900

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Mar 10, 2025

Closes

This separates out the verdaccio script so it can be parallelized. This means we can add new examples without worrying about increasing the build time even more.

While the savings from parallelizing it were unfortunately mostly matched by the overhead of persisting the workspace and non-shared yarn caches between example apps, I was able to save over a minute on the patch versioning.

Overall, comparison between this branch and main
This branch 23min
On main, at best 25min, at worst 30+min

while my run is a small sample size, main only had a single successful time under 25min in 3 months.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Mar 10, 2025

@rspbot
Copy link

rspbot commented Mar 10, 2025

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants