Skip to content

fix(Autocomplete): links not opening in new tab on meta key modifier #8997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2025
Merged

fix(Autocomplete): links not opening in new tab on meta key modifier #8997

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
33d1c22
fix: autocomplete links not opening in new tab on meta key modifier
reidbarber Oct 8, 2025
6a7b241
dispatch PointerEvent instead
reidbarber Oct 10, 2025
24931ce
Merge remote-tracking branch 'origin/main' into fix-autocomplete-link…
reidbarber Oct 10, 2025
08cf817
lint
reidbarber Oct 10, 2025
f5afec7
fire Mouse event instead
reidbarber Oct 10, 2025
838b9ad
use PointerEvent and fix test
reidbarber Oct 10, 2025
4e6b690
Merge remote-tracking branch 'origin/main' into fix-autocomplete-link…
reidbarber Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/@react-aria/autocomplete/src/useAutocomplete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
import {AriaLabelingProps, BaseEvent, DOMProps, FocusableElement, FocusEvents, KeyboardEvents, Node, RefObject, ValueBase} from '@react-types/shared';
import {AriaTextFieldProps} from '@react-aria/textfield';
import {AutocompleteProps, AutocompleteState} from '@react-stately/autocomplete';
import {CLEAR_FOCUS_EVENT, FOCUS_EVENT, getActiveElement, getOwnerDocument, isAndroid, isCtrlKeyPressed, isIOS, mergeProps, mergeRefs, useEffectEvent, useEvent, useId, useLabels, useObjectRef} from '@react-aria/utils';
import {CLEAR_FOCUS_EVENT, FOCUS_EVENT, getActiveElement, getOwnerDocument, isAndroid, isCtrlKeyPressed, isIOS, mergeProps, mergeRefs, openLink, useEffectEvent, useEvent, useId, useLabels, useObjectRef} from '@react-aria/utils';
import {dispatchVirtualBlur, dispatchVirtualFocus, getVirtuallyFocusedElement, moveVirtualFocus} from '@react-aria/focus';
import {getInteractionModality} from '@react-aria/interactions';
// @ts-ignore
Expand Down Expand Up @@ -311,7 +311,11 @@ export function useAutocomplete<T>(props: AriaAutocompleteOptions<T>, state: Aut
// Trigger click action on item when Enter key was pressed.
if (focusedNodeId != null) {
let item = document.getElementById(focusedNodeId);
item?.click();
if (item instanceof HTMLAnchorElement && item.href) {
openLink(item, e.nativeEvent);
} else if (item) {
item.click();
}
}
break;
}
Expand Down