- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.3k
fix: (DNM) Constrain day on blur #9082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            LFDanLu
  wants to merge
  55
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
test_constrained_date
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …ctrum into constrain-date
| Build successful! 🎉 | 
…/react-spectrum into constrain-date
…/react-spectrum into constrain-date
…/react-spectrum into test_constrained_date
bff759b    to
    028d2df      
    Compare
  
    | Build successful! 🎉 | 
| ## API Changes react-aria-components/react-aria-components:DateFieldState DateFieldState {
   calendar: Calendar
   clearSegment: (SegmentType) => void
   commitValidation: () => void
   confirmPlaceholder: () => void
   dateFormatter: DateFormatter
   dateValue: Date
   decrement: (SegmentType) => void
   decrementPage: (SegmentType) => void
   defaultValue: DateValue | null
   displayValidation: ValidationResult
   formatValue: (FieldOptions) => string
   getDateFormatter: (string, FormatterOptions) => DateFormatter
   granularity: Granularity
   increment: (SegmentType) => void
   incrementPage: (SegmentType) => void
+  incrementToMinMax: (SegmentType, number) => void
   isDisabled: boolean
   isInvalid: boolean
   isReadOnly: boolean
   isRequired: boolean
   maxGranularity: 'year' | 'month' | Granularity
   realtimeValidation: ValidationResult
   resetValidation: () => void
   segments: Array<DateSegment>
   setSegment: (SegmentType, number) => void
+  setShouldValidate: (boolean) => void
   setValue: (DateValue | null) => void
+  shouldValidate: boolean
   updateValidation: (ValidationResult) => void
   value: DateValue | null
 }/react-aria-components:TimeFieldState TimeFieldState {
   calendar: Calendar
   clearSegment: (SegmentType) => void
   commitValidation: () => void
   confirmPlaceholder: () => void
   dateFormatter: DateFormatter
   dateValue: Date
   decrement: (SegmentType) => void
   decrementPage: (SegmentType) => void
   defaultValue: DateValue | null
   displayValidation: ValidationResult
   formatValue: (FieldOptions) => string
   getDateFormatter: (string, FormatterOptions) => DateFormatter
   granularity: Granularity
   increment: (SegmentType) => void
   incrementPage: (SegmentType) => void
+  incrementToMinMax: (SegmentType, number) => void
   isDisabled: boolean
   isInvalid: boolean
   isReadOnly: boolean
   isRequired: boolean
   maxGranularity: 'year' | 'month' | Granularity
   realtimeValidation: ValidationResult
   resetValidation: () => void
   segments: Array<DateSegment>
   setSegment: (SegmentType, number) => void
+  setShouldValidate: (boolean) => void
   setValue: (DateValue | null) => void
+  shouldValidate: boolean
   timeValue: Time
   updateValidation: (ValidationResult) => void
   value: DateValue | null
 }@internationalized/date/@internationalized/date:Calendar Calendar {
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getEras: () => Array<string>
   getFormattableMonth: (AnyCalendarDate) => CalendarDate
+  getMaxDays: () => number
   getMinimumDayInMonth: (AnyCalendarDate) => number
   getMinimumMonthInYear: (AnyCalendarDate) => number
   getMonthsInYear: (AnyCalendarDate) => number
   getYearsInEra: (AnyCalendarDate) => number
   isEqual: (Calendar) => boolean
   toJulianDay: (AnyCalendarDate) => number
 }/@internationalized/date:CalendarDate CalendarDate {
   add: (DateDuration) => CalendarDate
   calendar: Calendar
   compare: (AnyCalendarDate) => number
   constructor: (Array<any>) => void
-  copy: () => CalendarDate
-  cycle: (DateField, number, CycleOptions) => CalendarDate
+  copy: (boolean) => CalendarDate
+  cycle: (DateField, number, CycleOptions, boolean) => CalendarDate
   day: number
   era: string
   month: number
-  set: (DateFields) => CalendarDate
+  set: (DateFields, boolean) => CalendarDate
   subtract: (DateDuration) => CalendarDate
   toDate: (string) => Date
   toString: () => string
   UNKNOWN: any
 }/@internationalized/date:CalendarDateTime CalendarDateTime {
   add: (DateTimeDuration) => CalendarDateTime
   calendar: Calendar
   compare: (CalendarDate | CalendarDateTime | ZonedDateTime) => number
   constructor: (Array<any>) => void
-  copy: () => CalendarDateTime
-  cycle: (DateField | TimeField, number, CycleTimeOptions) => CalendarDateTime
+  copy: (boolean) => CalendarDateTime
+  cycle: (DateField | TimeField, number, CycleTimeOptions, boolean) => CalendarDateTime
   day: number
   era: string
   hour: number
   millisecond: number
   minute: number
   month: number
   second: number
-  set: ((DateFields & TimeFields)) => CalendarDateTime
+  set: ((DateFields & TimeFields), boolean) => CalendarDateTime
   subtract: (DateTimeDuration) => CalendarDateTime
   toDate: (string, Disambiguation) => Date
   toString: () => string
   UNKNOWN: any
 }/@internationalized/date:Time Time {
   add: (TimeDuration) => Time
   compare: (AnyTime) => number
   constructor: (number, number, number, number) => void
   copy: () => Time
   cycle: (TimeField, number, CycleTimeOptions) => Time
   hour: number
   millisecond: number
   minute: number
   second: number
-  set: (TimeFields) => Time
+  set: (TimeFields, boolean) => Time
   subtract: (TimeDuration) => Time
   toString: () => string
   UNKNOWN: any
 }/@internationalized/date:ZonedDateTime ZonedDateTime {
   add: (DateTimeDuration) => ZonedDateTime
   calendar: Calendar
   compare: (CalendarDate | CalendarDateTime | ZonedDateTime) => number
   constructor: (Array<any>) => void
-  copy: () => ZonedDateTime
-  cycle: (DateField | TimeField, number, CycleTimeOptions) => ZonedDateTime
+  copy: (boolean) => ZonedDateTime
+  cycle: (DateField | TimeField, number, CycleTimeOptions, boolean) => ZonedDateTime
   day: number
   era: string
   hour: number
   millisecond: number
   minute: number
   month: number
   offset: number
   second: number
-  set: ((DateFields & TimeFields), Disambiguation) => ZonedDateTime
+  set: ((DateFields & TimeFields), Disambiguation | boolean) => ZonedDateTime
   subtract: (DateTimeDuration) => ZonedDateTime
   timeZone: string
   toAbsoluteString: () => string
   toDate: () => Date
   UNKNOWN: any
   year: number
 }/@internationalized/date:GregorianCalendar GregorianCalendar {
   balanceDate: (Mutable<AnyCalendarDate>) => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: (AnyCalendarDate) => number
   getYearsInEra: (AnyCalendarDate) => number
   identifier: CalendarIdentifier
   isInverseEra: (AnyCalendarDate) => boolean
 }/@internationalized/date:JapaneseCalendar JapaneseCalendar {
   balanceDate: (Mutable<AnyCalendarDate>) => void
   constrainDate: (Mutable<AnyCalendarDate>) => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMinimumDayInMonth: (AnyCalendarDate) => number
   getMinimumMonthInYear: (AnyCalendarDate) => number
   getMonthsInYear: (AnyCalendarDate) => number
   getYearsInEra: (AnyCalendarDate) => number
   isInverseEra: (AnyCalendarDate) => boolean
   toJulianDay: (AnyCalendarDate) => number
 }/@internationalized/date:BuddhistCalendar BuddhistCalendar {
   balanceDate: () => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: (AnyCalendarDate) => number
   getYearsInEra: (AnyCalendarDate) => number
   identifier: CalendarIdentifier
   isInverseEra: (AnyCalendarDate) => boolean
 }/@internationalized/date:TaiwanCalendar TaiwanCalendar {
   balanceDate: (Mutable<AnyCalendarDate>) => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: (AnyCalendarDate) => number
   getYearsInEra: (AnyCalendarDate) => number
   identifier: CalendarIdentifier
   isInverseEra: (AnyCalendarDate) => boolean
 }/@internationalized/date:PersianCalendar PersianCalendar {
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: () => number
   getYearsInEra: () => number
   identifier: CalendarIdentifier
   toJulianDay: (AnyCalendarDate) => number/@internationalized/date:IndianCalendar IndianCalendar {
   balanceDate: () => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: (AnyCalendarDate) => number
   getYearsInEra: () => number
   identifier: CalendarIdentifier
   isInverseEra: (AnyCalendarDate) => boolean
 }/@internationalized/date:IslamicCivilCalendar IslamicCivilCalendar {
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: () => number
   getYearsInEra: () => number
   identifier: CalendarIdentifier
   toJulianDay: (AnyCalendarDate) => number/@internationalized/date:IslamicTabularCalendar IslamicTabularCalendar {
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: () => number
   getYearsInEra: () => number
   identifier: CalendarIdentifier
   toJulianDay: (AnyCalendarDate) => number/@internationalized/date:IslamicUmalquraCalendar IslamicUmalquraCalendar {
   constructor: () => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: () => number
   getYearsInEra: () => number
   identifier: CalendarIdentifier
   toJulianDay: (AnyCalendarDate) => number/@internationalized/date:HebrewCalendar HebrewCalendar {
   balanceYearMonth: (Mutable<AnyCalendarDate>, AnyCalendarDate) => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: (AnyCalendarDate) => number
   getYearsInEra: () => number
   identifier: CalendarIdentifier
   toJulianDay: (AnyCalendarDate) => number/@internationalized/date:EthiopicCalendar EthiopicCalendar {
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: () => number
   getYearsInEra: (AnyCalendarDate) => number
   identifier: CalendarIdentifier
   toJulianDay: (AnyCalendarDate) => number/@internationalized/date:EthiopicAmeteAlemCalendar EthiopicAmeteAlemCalendar {
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: () => number
   getYearsInEra: () => number
   identifier: CalendarIdentifier
   toJulianDay: (AnyCalendarDate) => number/@internationalized/date:CopticCalendar CopticCalendar {
   balanceDate: (Mutable<AnyCalendarDate>) => void
   fromJulianDay: (number) => CalendarDate
   getDaysInMonth: (AnyCalendarDate) => number
   getDaysInYear: (AnyCalendarDate) => number
   getEras: () => Array<string>
+  getMaxDays: () => number
   getMonthsInYear: () => number
   getYearsInEra: (AnyCalendarDate) => number
   identifier: CalendarIdentifier
   isInverseEra: (AnyCalendarDate) => boolean
 }/@internationalized/date:toCalendar toCalendar <T extends AnyCalendarDate> {
   date: T
   calendar: Calendar
+  constrainDay?: boolean
   returnVal: undefined
 }@react-stately/datepicker/@react-stately/datepicker:DateFieldState DateFieldState {
   calendar: Calendar
   clearSegment: (SegmentType) => void
   commitValidation: () => void
   confirmPlaceholder: () => void
   dateFormatter: DateFormatter
   dateValue: Date
   decrement: (SegmentType) => void
   decrementPage: (SegmentType) => void
   defaultValue: DateValue | null
   displayValidation: ValidationResult
   formatValue: (FieldOptions) => string
   getDateFormatter: (string, FormatterOptions) => DateFormatter
   granularity: Granularity
   increment: (SegmentType) => void
   incrementPage: (SegmentType) => void
+  incrementToMinMax: (SegmentType, number) => void
   isDisabled: boolean
   isInvalid: boolean
   isReadOnly: boolean
   isRequired: boolean
   maxGranularity: 'year' | 'month' | Granularity
   realtimeValidation: ValidationResult
   resetValidation: () => void
   segments: Array<DateSegment>
   setSegment: (SegmentType, number) => void
+  setShouldValidate: (boolean) => void
   setValue: (DateValue | null) => void
+  shouldValidate: boolean
   updateValidation: (ValidationResult) => void
   value: DateValue | null
 }/@react-stately/datepicker:TimeFieldState TimeFieldState {
   calendar: Calendar
   clearSegment: (SegmentType) => void
   commitValidation: () => void
   confirmPlaceholder: () => void
   dateFormatter: DateFormatter
   dateValue: Date
   decrement: (SegmentType) => void
   decrementPage: (SegmentType) => void
   defaultValue: DateValue | null
   displayValidation: ValidationResult
   formatValue: (FieldOptions) => string
   getDateFormatter: (string, FormatterOptions) => DateFormatter
   granularity: Granularity
   increment: (SegmentType) => void
   incrementPage: (SegmentType) => void
+  incrementToMinMax: (SegmentType, number) => void
   isDisabled: boolean
   isInvalid: boolean
   isReadOnly: boolean
   isRequired: boolean
   maxGranularity: 'year' | 'month' | Granularity
   realtimeValidation: ValidationResult
   resetValidation: () => void
   segments: Array<DateSegment>
   setSegment: (SegmentType, number) => void
+  setShouldValidate: (boolean) => void
   setValue: (DateValue | null) => void
+  shouldValidate: boolean
   timeValue: Time
   updateValidation: (ValidationResult) => void
   value: DateValue | null
 } | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
courtesy of #8385, so we have a build to test on Monday
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: