Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Nov 25, 2025

Closes #8160

Also fixes the following:

  • RAC toast docs should work regardless if the user is on the vanilla CSS example or Tailwind example
  • Necessity asterix from setting isRequired should only include the additional announcing for CheckboxGroup and Picker. Otherwise, the icon should be aria-hidden since the field already has been marked as required
  • Apply a default className of "" to S2 Tabs' picker that appears when there are too many tabs to render at once. This prevents styles applied to the default RAC Select class name from affecting the S2 Tabs' picker. This makes the FileTabs in the CodeBlock in the new docs render with the proper picker underline width instead of always being 200px

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

See the above, and also test that the autocomplete input field doesn't get automatically focused when tapping on a wrapped collection's item/row on mobile.

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Nov 25, 2025

@rspbot
Copy link

rspbot commented Nov 26, 2025

};

if (typeof PointerEvent !== 'undefined') {
document.addEventListener('pointerdown', handlePointerDown, true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized one case this won't handle: if the last pointer event happened before the autocomplete mounted. We may need to track the pointer type globally. useFocusVisible does this already but only stores "pointer" rather than the actual pointer type...

@devongovett devongovett added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 02b8800 Dec 1, 2025
33 checks passed
@devongovett devongovett deleted the testing_fixes_1124 branch December 1, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocomplete: option for disabling auto-focus of search field?

5 participants