Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency @spectrum-css/search to v8.1.1 #5343

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update dependency @spectrum-css/search to v8.1.1 #5343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d142d4f
chore: update dependency @spectrum-css/search to v8.1.1
renovate[bot] Apr 4, 2025
fc1809e
fix(search,styles): use latest CSS
castastrophe Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/chilly-turkeys-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@spectrum-web-components/search': patch
'@spectrum-web-components/styles': patch
---

📝 [#​3593](https://github.com/adobe/spectrum-css/pull/3593) Thanks [@​TarunAdobe](https://github.com/TarunAdobe)!

Updated `--spectrum-search-background-color-disabled` to `--spectrum-gray-25` and `--spectrum-search-border-color-disabled` to `--spectrum-gray-300` for the S2 foundations contexts.

Also defines disabled quiet border and background colors (`--system-search-quiet-background-color-disabled` and `--system-search-quiet-border-color-disabled`) in order to maintain disabled quiet styling.
2 changes: 1 addition & 1 deletion packages/search/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@spectrum-web-components/textfield": "1.4.0"
},
"devDependencies": {
"@spectrum-css/search": "8.0.0-s2-foundations.19"
"@spectrum-css/search": "8.1.1"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
15 changes: 15 additions & 0 deletions packages/search/src/search-overrides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ governing permissions and limitations under the License.
--system-search-border-color-key-focus
);
--spectrum-search-background-color: var(--system-search-background-color);
--spectrum-search-background-color-disabled: var(
--system-search-background-color-disabled
);
--spectrum-search-border-color-disabled: var(
--system-search-border-color-disabled
);
--spectrum-search-border-radius: var(--system-search-border-radius);
--spectrum-search-edge-to-visual: var(--system-search-edge-to-visual);
}
Expand All @@ -38,3 +44,12 @@ governing permissions and limitations under the License.
--system-search-size-m-edge-to-visual
);
}

:host([quiet]) {
--spectrum-search-background-color-disabled: var(
--system-search-quiet-background-color-disabled
);
--spectrum-search-border-color-disabled: var(
--system-search-quiet-border-color-disabled
);
}
2 changes: 0 additions & 2 deletions packages/search/src/spectrum-search.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ governing permissions and limitations under the License.
--spectrum-search-color-key-focus: var(--spectrum-neutral-content-color-key-focus);
--spectrum-search-border-width: var(--spectrum-border-width-100);
--spectrum-search-color-disabled: var(--spectrum-disabled-content-color);
--spectrum-search-background-color-disabled: var(--spectrum-disabled-background-color);
--spectrum-search-border-color-disabled: var(--spectrum-disabled-background-color);
--mod-textfield-font-family: var(--mod-search-font-family, var(--spectrum-search-font-family));
--mod-textfield-font-weight: var(--mod-search-font-weight, var(--spectrum-search-font-weight));
--mod-textfield-corner-radius: var(--mod-search-border-radius, var(--spectrum-search-border-radius));
Expand Down
6 changes: 6 additions & 0 deletions tools/styles/tokens-v2/system-theme-bridge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,8 @@
--system-search-border-color-focus-hover: var(--spectrum-gray-900);
--system-search-border-color-key-focus: var(--spectrum-gray-900);
--system-search-background-color: var(--spectrum-gray-25);
--system-search-background-color-disabled: var(--spectrum-gray-25);
--system-search-border-color-disabled: var(--spectrum-gray-300);
--system-search-border-radius: var(--spectrum-corner-radius-100);
--system-search-size-m-border-radius: var(--spectrum-corner-radius-100);
--system-search-edge-to-visual: var(
Expand All @@ -1249,6 +1251,10 @@
--system-search-size-xl-edge-to-visual: var(
--spectrum-component-edge-to-visual-300
);
--system-search-quiet-background-color-disabled: transparent;
--system-search-quiet-border-color-disabled: var(
--spectrum-disabled-border-color
);
--system-side-nav-background-hover: var(--spectrum-gray-100);
--system-side-nav-item-background-down: var(--spectrum-gray-200);
--system-side-nav-background-key-focus: var(--spectrum-gray-100);
Expand Down
10 changes: 10 additions & 0 deletions tools/styles/tokens/express/system-theme-bridge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,12 @@
--system-search-border-color-focus-hover: var(--spectrum-gray-900);
--system-search-border-color-key-focus: var(--spectrum-gray-900);
--system-search-background-color: var(--spectrum-gray-50);
--system-search-background-color-disabled: var(
--spectrum-disabled-background-color
);
--system-search-border-color-disabled: var(
--spectrum-disabled-background-color
);
--system-search-border-radius: calc(
var(--spectrum-component-height-100) / 2
);
Expand Down Expand Up @@ -1277,6 +1283,10 @@
--system-search-size-xl-edge-to-visual: var(
--spectrum-component-pill-edge-to-visual-300
);
--system-search-quiet-background-color-disabled: transparent;
--system-search-quiet-border-color-disabled: var(
--spectrum-disabled-border-color
);
--system-side-nav-background-hover: var(--spectrum-gray-200);
--system-side-nav-item-background-down: var(--spectrum-gray-300);
--system-side-nav-background-key-focus: var(--spectrum-gray-200);
Expand Down
10 changes: 10 additions & 0 deletions tools/styles/tokens/spectrum/system-theme-bridge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,12 @@
--system-search-border-color-focus-hover: var(--spectrum-gray-900);
--system-search-border-color-key-focus: var(--spectrum-gray-900);
--system-search-background-color: var(--spectrum-gray-50);
--system-search-background-color-disabled: var(
--spectrum-disabled-background-color
);
--system-search-border-color-disabled: var(
--spectrum-disabled-background-color
);
--system-search-border-radius: var(--spectrum-corner-radius-100);
--system-search-size-m-border-radius: var(--spectrum-corner-radius-100);
--system-search-edge-to-visual: var(
Expand All @@ -1267,6 +1273,10 @@
--system-search-size-xl-edge-to-visual: var(
--spectrum-component-edge-to-visual-300
);
--system-search-quiet-background-color-disabled: transparent;
--system-search-quiet-border-color-disabled: var(
--spectrum-disabled-border-color
);
--system-side-nav-background-hover: var(--spectrum-gray-200);
--system-side-nav-item-background-down: var(--spectrum-gray-300);
--system-side-nav-background-key-focus: var(--spectrum-gray-200);
Expand Down
27 changes: 18 additions & 9 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7547,15 +7547,24 @@ __metadata:
languageName: node
linkType: hard

"@spectrum-css/search@npm:8.0.0-s2-foundations.19":
version: 8.0.0-s2-foundations.19
resolution: "@spectrum-css/search@npm:8.0.0-s2-foundations.19"
"@spectrum-css/search@npm:8.1.1":
version: 8.1.1
resolution: "@spectrum-css/search@npm:8.1.1"
peerDependencies:
"@spectrum-css/clearbutton": ">=6"
"@spectrum-css/icon": ">=7"
"@spectrum-css/textfield": ">=7"
"@spectrum-css/tokens": ">=14"
checksum: 10c0/8ee475d3978032a5c66e46eee175bbc80f6b376bcab4fa7abfc63d6b30b392245d949db7f89be028463d20a00ebe5346d951c1ddc6a9e4858a7406841e8ecdfd
"@spectrum-css/clearbutton": ">=7.0.0 <8.0.0"
"@spectrum-css/icon": ">=9.0.0 <10.0.0"
"@spectrum-css/textfield": ">=8.0.0 <9.0.0"
"@spectrum-css/tokens": ">=16.0.0 <17.0.0"
peerDependenciesMeta:
"@spectrum-css/clearbutton":
optional: true
"@spectrum-css/icon":
optional: true
"@spectrum-css/textfield":
optional: true
"@spectrum-css/tokens":
optional: true
checksum: 10c0/9d68c9f1cc77797b47a74adac9f69bc51869527ace3cb305dead7e86dbb04f0000f30b28544d2dd2f0561304af9b0bb957489ae49de7b8dcc7ed047d567f9c3c
languageName: node
linkType: hard

Expand Down Expand Up @@ -8669,7 +8678,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@spectrum-web-components/search@workspace:packages/search"
dependencies:
"@spectrum-css/search": "npm:8.0.0-s2-foundations.19"
"@spectrum-css/search": "npm:8.1.1"
"@spectrum-web-components/base": "npm:1.4.0"
"@spectrum-web-components/button": "npm:1.4.0"
"@spectrum-web-components/icon": "npm:1.4.0"
Expand Down
Loading