Skip to content

Conversation

TarunAdobe
Copy link
Contributor

@TarunAdobe TarunAdobe commented Oct 7, 2025

Description

  • Added build-, test-, start-, and lint- root scripts so first- and second-gen workspaces can be orchestrated together.
  • Introduced a prebuild wireit target in first-gen/package.json that triggers the second-gen core build before the existing build pipeline.
  • Renamed the second-gen workspace to @adobe/swc and updated yarn.lock to reflect the new package name.

Motivation and context

  • Make the root package the single entry point for common dev workflows that span both generations of Spectrum Web Components.
  • Ensure first-gen builds automatically compile second-gen core artifacts to keep shared output in sync.

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Copy link

changeset-bot bot commented Oct 7, 2025

⚠️ No Changeset found

Latest commit: ffa43cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 7, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5791

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Tachometer results

Currently, no packages are changed by this PR...

@TarunAdobe TarunAdobe changed the title chore: hoist dev commands to root packagejson chore: command orchestration Oct 7, 2025
@TarunAdobe TarunAdobe marked this pull request as ready for review October 8, 2025 05:54
@TarunAdobe TarunAdobe requested a review from a team as a code owner October 8, 2025 05:54
@TarunAdobe TarunAdobe self-assigned this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant