refactor: default sort by most downloaded packages

adonisjs-community · Jan 21, 2024 · be92dda · be92dda
1 parent faea546
commit be92dda
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/app/services/packages_fetcher.ts b/app/services/packages_fetcher.ts
@@ -40,7 +40,7 @@ export class PackagesFetcher {
       const valueB = b[property]
 
       if (typeof valueA === 'number' && typeof valueB === 'number') {
-        return valueA - valueB * order
+        return (valueA - valueB) * order
       }
 
       if (typeof valueA === 'string' && typeof valueB === 'string') {
@@ -146,11 +146,13 @@ export class PackagesFetcher {
     /**
      * Sort the results
      */
+    console.log(options)
     const sortedPackages = this.#sortPackages(
-      options.order ?? 1,
-      options.orderBy ?? 'name',
+      options.order ?? -1,
+      options.orderBy ?? 'downloads',
       packages,
     )
+    console.log(sortedPackages)
 
     /**
      * Paginate the results

diff --git a/content/packages/cavai-queue.yml b/content/packages/cavai-queue.yml
@@ -1,4 +1,4 @@
-name: '@cavai/adonis-queue'
+name: 'cavai/adonis-queue'
 description: Queue package for Adonis V5. Comes with built-in database driver and allows easy extension with custom drivers
 repo: cavai-research/Adonis-Queue
 npm: '@cavai/adonis-queue'

diff --git a/resources/pages/home/main.vue b/resources/pages/home/main.vue
@@ -67,8 +67,8 @@ const orderByOptions = [
     description: 'Sort packages by their last update date',
   },
 ]
-const order = ref<SortOrder>(params.order ? (+params.order as SortOrder) : 1)
-const orderBy = ref<string>(params.orderBy || orderByOptions[0].value)
+const order = ref<SortOrder>(params.order ? (+params.order as SortOrder) : -1)
+const orderBy = ref<string>(params.orderBy || orderByOptions[3].value)
 
 /**
  * Filters