bug: Support when border-spacing returns a single value #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-sortable canceled.
|
NullVoxPopuli
previously approved these changes
Jan 10, 2025
This is mostly a workaround for a [potential bug introduced with Firefox 134](https://bugzilla.mozilla.org/show_bug.cgi?id=1941066) Based on the spec, `getComputedStyle(el).borderSpacing` should always return 2 values, even when they are identical. On Firefox 134, it returns a single value when they are the same.
cyril-sf
force-pushed
the
bug/border-spacing-firefox
branch
from
c4e04e9 to
96f0116
Compare
|
@NullVoxPopuli lint fixed! |
NullVoxPopuli
approved these changes
Jan 13, 2025
NullVoxPopuli
merged commit 5ceca29
into
adopted-ember-addons:master
21 of 22 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a workaround for a potential bug introduced with Firefox 134
Based on the spec,
getComputedStyle(el).borderSpacingshould always return 2 values, even when they are identical.On Firefox 134, it returns a single value when they are the same.
Fixes #607