Entrypoint fixes for CA certificates feature #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids clashing with pre-existing downstream images which have used a custom entrypoint script at e.g. /entrypoint.sh
|
@gdams here you go. Do we need the original commit in here? |
gdams
reviewed
Aug 14, 2023
gdams
reviewed
Aug 14, 2023
|
Oh, damn, I need to generate all the stuff first. Sorry, coming right up. |
gdams
approved these changes
Aug 14, 2023
gdams
force-pushed
the
cacerts-entrypoint-fixes
branch
from
51c48ab
to
b1af31e
Compare
@rassie no need, the automation will handle that on merge |
Oh, cool, didn't know that. Same for tests? |
hendrikebbers
approved these changes
Aug 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two problems with current implementation:
/entrypoint.shis a common file location for custom entrypoint scripts for images without a non-default entrypoint. Putting our entrypoint script there might lead to name clashes.shas shebang for the entrypoint scripts destroys environment variables with invalid names (e.g. with dots in them). Usingbashas shebang avoids this problem, sincebashkeeps those variables as-is.Ref: #392 (#392 (comment))
Fixes: #415