Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase JVM memory percentage #433

Closed
wants to merge 1 commit into from
Closed

Increase JVM memory percentage #433

wants to merge 1 commit into from

Conversation

tariqajyusuf
Copy link

The JVM by default uses only 25% of the system memory. In a container environment we should have this larger so that the system doesn't necessarily go through memory thrash despite most of the allocated memory still being available.

@tariqajyusuf tariqajyusuf marked this pull request as ready for review October 11, 2023 19:31
@karianna
Copy link
Contributor

This is a per user/per application setting that you'll need to add but we can't add this for everyone.

@karianna karianna closed this Oct 11, 2023
@tariqajyusuf
Copy link
Author

tariqajyusuf commented Oct 11, 2023 via email

@karianna
Copy link
Contributor

https://learn.microsoft.com/en-us/azure/developer/java/containers/kubernetes?source=recommendations for reference - the JVM ergonomics are dynamic and should ideally be set by the user for their workload.

@tariqajyusuf
Copy link
Author

Got it, it feels like this should be a default change instead of requiring two different configurations that are often going to be the same.

With this practice, it may be worth considering including documentation in adaptium's docker README. I tested a number of well used JVM based images that don't set this so I suspect this is a setting that a lot of people are not aware of.

@karianna
Copy link
Contributor

separately Microsoft is working on improving ergonomics profiles for containers - see https://github.com/microsoft/openjdk-proposals/blob/main/ergonomics_profiles/readme.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants