further dockerfile refactor enhancements #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
force-pushed
the
enhancements
branch
4 times, most recently
from
ef9986e
to
68e7b03
Compare
karianna
approved these changes
Oct 27, 2023
tellison
approved these changes
Oct 30, 2023
sxa
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Lots Lots of changes in here with refactoring etc. but as far as I can tell it looks good assuming the .j2 changes are ok. Noting also that the Windows version does not include the .1 suffix to make it easier for the upstream docker tags.
Also we should review the need for zlib and libretls in the Alpine images post-release under #458 as I'm fairly certain zlib is no longer required as we use bundled zlib in the builds now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue blocking our release process (and a few other minor refactors)