-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfiles #666
Update Dockerfiles #666
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
builds failing
I wonder if we should install QEMU as part of the action so this job would pass in this situation |
If you don't have x86-64 binaries yet, don't you want the CI to fail? Arguably maybe even if arm64 binaries are missing too? (I think I'm missing something for why you'd want them to pass with missing release artifacts 😅) |
it's not uncommon for us to publish binaries in a slightly random order (although Linux x64 is normally one of the first). We have some separate tooling that reports back to us if all of the architectures are available for a given dockerfile so it's actually safe to merge a PR in this situation. I've added a setup-qemu step to our CI which should catch this edge case |
This is an automatically generated pull request, it will be automatically merged if all the CI tests pass.