Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfiles #666

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Update Dockerfiles #666

merged 11 commits into from
Oct 18, 2024

Conversation

eclipse-temurin-bot
Copy link
Contributor

This is an automatically generated pull request, it will be automatically merged if all the CI tests pass.

@github-actions github-actions bot enabled auto-merge (squash) October 17, 2024 13:37
@karianna

This comment was marked as outdated.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds failing

@gdams
Copy link
Member

gdams commented Oct 17, 2024

For some reason the tooling is trying to build linux/arm64/v8. @tianon /@yosifkit any ideas what might have changed?

@gdams
Copy link
Member

gdams commented Oct 17, 2024

For some reason the tooling is trying to build linux/arm64/v8. @tianon /@yosifkit any ideas what might have changed?

Oh wait, we haven't published jdk17 binaries for x64 linux yet. I guess this is intentional behaviour then

@gdams
Copy link
Member

gdams commented Oct 17, 2024

I wonder if we should install QEMU as part of the action so this job would pass in this situation

@tianon
Copy link

tianon commented Oct 17, 2024

If you don't have x86-64 binaries yet, don't you want the CI to fail? Arguably maybe even if arm64 binaries are missing too? (I think I'm missing something for why you'd want them to pass with missing release artifacts 😅)

@gdams
Copy link
Member

gdams commented Oct 18, 2024

If you don't have x86-64 binaries yet, don't you want the CI to fail? Arguably maybe even if arm64 binaries are missing too? (I think I'm missing something for why you'd want them to pass with missing release artifacts 😅)

it's not uncommon for us to publish binaries in a slightly random order (although Linux x64 is normally one of the first). We have some separate tooling that reports back to us if all of the architectures are available for a given dockerfile so it's actually safe to merge a PR in this situation. I've added a setup-qemu step to our CI which should catch this edge case

@github-actions github-actions bot merged commit 961207c into main Oct 18, 2024
74 checks passed
@github-actions github-actions bot deleted the dockerfile_bot branch October 18, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants