-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open routed URL in a new tab #339
Open routed URL in a new tab #339
Conversation
✅ Deploy Preview for eclipsefdn-adoptium-dash ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It seems to work in the deploy preview: https://deploy-preview-339--eclipsefdn-adoptium-dash.netlify.app/trends I'll just try to add the correct select Tab depending off the current route. |
✔️ Rewritings are goods
It doesn't build with my last modification. Let's just fix the rewriting for now |
8e297ed
to
c25d0d6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I don't know HashRouter, but I know that rewriting works well and it was a quick fix for existing urls. |
I tested the implemented solution and it works nice. I think its a better approach than the HashRouter. |
Try to fix issue #272