Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Docker Pulls" bar chart at the bottom #363

Conversation

xavierfacq
Copy link
Member

@xavierfacq xavierfacq commented Sep 26, 2023

This PR is related to the issues #349

Remove the Docker pulls from the bottom (duplicated with the pie chart)

I have also:

  • remove expect(container).toMatchSnapshot(); because HightChart generates differents values at runtime
  • Add a new Test file on the Download component

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for eclipsefdn-adoptium-dash ready!

Name Link
🔨 Latest commit 05c4fd9
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-dash/deploys/6513241e52c3ff0008f42674
😎 Deploy Preview https://deploy-preview-363--eclipsefdn-adoptium-dash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #363 (05c4fd9) into main (c6984d4) will increase coverage by 38.57%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #363       +/-   ##
===========================================
+ Coverage   13.66%   52.24%   +38.57%     
===========================================
  Files           9        9               
  Lines         849      848        -1     
  Branches       17       34       +17     
===========================================
+ Hits          116      443      +327     
+ Misses        733      405      -328     
Files Coverage Δ
src/Graph/Download.tsx 100.00% <ø> (+100.00%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq marked this pull request as ready for review September 26, 2023 18:36
@gdams gdams linked an issue Sep 26, 2023 that may be closed by this pull request
@gdams gdams merged commit 2f1b385 into adoptium:main Sep 26, 2023
10 checks passed
@xavierfacq xavierfacq deleted the fix/dash-349_remove_Docker_Pulls_bar_chart_at_the_bottom branch October 5, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker pulls bar chart is not useful
2 participants