Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test avoid warnings #365

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

xavierfacq
Copy link
Member

What is done:

  • Improve tests to avoid errors
  • Add AccessibilityModule in tests
  • Allow attribute 'rel' in Highcharts (was a warning)
  • Add a small test on Trends component

[x] npm test passes

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for eclipsefdn-adoptium-dash ready!

Name Link
🔨 Latest commit d24191c
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-dash/deploys/6513e598d735500008e2f512
😎 Deploy Preview https://deploy-preview-365--eclipsefdn-adoptium-dash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #365 (d24191c) into main (2f1b385) will increase coverage by 43.86%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #365       +/-   ##
===========================================
+ Coverage   52.24%   96.10%   +43.86%     
===========================================
  Files           9        9               
  Lines         848      848               
  Branches       34       66       +32     
===========================================
+ Hits          443      815      +372     
+ Misses        405       33      -372     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq marked this pull request as ready for review September 27, 2023 08:21
@gdams gdams merged commit 7609f9d into adoptium:main Sep 27, 2023
10 checks passed
@xavierfacq xavierfacq deleted the improve_test_avoid_warnings branch October 5, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants