Listen for SAML login requests #1219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpfeiffer
reviewed
May 23, 2024
| free(cfg->domain_suffix); | ||
| cfg->domain_suffix = val; | ||
| continue; | ||
| } else if (strcmp(key, "dns") == 0) { |
There was a problem hiding this comment.
AFAICS this block is never reached due to the same if-clause above.
cpfeiffer
reviewed
May 23, 2024
| continue; | ||
| } else if (strcmp(key, "saml-login") == 0) { | ||
| free(cfg->saml_port); | ||
| cfg->saml_port = atol(val); |
There was a problem hiding this comment.
Are we freeing an int here? And why atol instead of atoi when saml_port is actually an int?
|
Any updates on this? Just had to go through the rather cumbersome SAML flow with openfortivpn-webview and realized that this branch obsoletes that method entirely. Hoping this can be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When started with
--saml-loginthe program creates a http server that accepts SAML login requestsThe server will remain open and refresh the connection whenever a request is made
The solution also implements a method of overriding the routes from the server with ones specified in the config file
It needs a little more work on the logging part.