Skip to content

Fix race conditions from unawaited async forEach callbacks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aegilops merged 3 commits into from
Dec 8, 2025
Merged

Fix race conditions from unawaited async forEach callbacks #27

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2296bd
Initial plan
Copilot Dec 5, 2025
22fde03
Convert async forEach loops to for...of loops to fix race conditions
Copilot Dec 5, 2025
f119054
Add proper type definitions for ComponentDetectionPackage constructor
Copilot Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions src/componentDetection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,15 @@ export default class ComponentDetection {
const packageCache = new PackageCache();
const packages: Array<ComponentDetectionPackage> = [];

componentsFound.forEach(async (component: any) => {
for (const component of componentsFound) {
// Skip components without packageUrl
if (!component.component.packageUrl) {
console.debug(`Skipping component detected without packageUrl: ${JSON.stringify({
id: component.component.id,
name: component.component.name || 'unnamed',
type: component.component.type || 'unknown'
}, null, 2)}`);
return;
continue;
}

console.debug(`Processing component: ${component.component.id}`);
Expand All @@ -150,7 +150,7 @@ export default class ComponentDetection {
// Skip if the packageUrl is empty (indicates an invalid or missing packageUrl)
if (!packageUrl) {
console.debug(`Skipping component with invalid packageUrl: ${component.component.id}`);
return;
continue;
}

if (!packageCache.hasPackage(packageUrl)) {
Expand All @@ -159,16 +159,16 @@ export default class ComponentDetection {
packageCache.addPackage(pkg);
packages.push(pkg);
}
});
}

// Set the transitive dependencies
console.debug("Sorting out transitive dependencies");
packages.forEach(async (pkg: ComponentDetectionPackage) => {
pkg.topLevelReferrers.forEach(async (referrer: any) => {
for (const pkg of packages) {
for (const referrer of pkg.topLevelReferrers) {
// Skip if referrer doesn't have a valid packageUrl
if (!referrer.packageUrl) {
console.debug(`Skipping referrer without packageUrl for component: ${pkg.id}`);
return;
continue;
}

const referrerUrl = ComponentDetection.makePackageUrl(referrer.packageUrl);
Expand All @@ -177,23 +177,23 @@ export default class ComponentDetection {
// Skip if the generated packageUrl is empty
if (!referrerUrl) {
console.debug(`Skipping referrer with invalid packageUrl for component: ${pkg.id}`);
return;
continue;
}

try {
const referrerPackage = packageCache.lookupPackage(referrerUrl);
if (referrerPackage === pkg) {
console.debug(`Found self-reference for package: ${pkg.id}`);
return; // Skip self-references
continue; // Skip self-references
}
if (referrerPackage) {
referrerPackage.dependsOn(pkg);
}
} catch (error) {
console.debug(`Error looking up referrer package: ${error}`);
}
});
});
}
}

// Create manifests
const manifests: Array<Manifest> = [];
Expand Down Expand Up @@ -364,11 +364,19 @@ export default class ComponentDetection {
}
}

/**
* Type for referrer objects in topLevelReferrers array
*/
type TopLevelReferrer = {
packageUrl?: any;
packageUrlString?: string;
};

class ComponentDetectionPackage extends Package {
public packageUrlString: string;

constructor(packageUrl: string, public id: string, public isDevelopmentDependency: boolean, public topLevelReferrers: [],
public locationsFoundAt: [], public containerDetailIds: [], public containerLayerIds: []) {
constructor(packageUrl: string, public id: string, public isDevelopmentDependency: boolean, public topLevelReferrers: TopLevelReferrer[],
public locationsFoundAt: string[], public containerDetailIds: string[], public containerLayerIds: string[]) {
super(packageUrl);
this.packageUrlString = packageUrl;
}
Expand Down