Express.js Open Redirect in malformed URLs
Moderate severity
GitHub Reviewed
Published
Mar 25, 2024
in
expressjs/express
•
Updated Mar 27, 2024
Package
Affected versions
< 4.19.2
>= 5.0.0-alpha.1, < 5.0.0-beta.3
Patched versions
4.19.2
5.0.0-beta.3
Description
Published to the GitHub Advisory Database
Mar 25, 2024
Reviewed
Mar 25, 2024
Published by the National Vulnerability Database
Mar 25, 2024
Last updated
Mar 27, 2024
Impact
Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.
When a user of Express performs a redirect using a user-provided URL Express performs an encode using
encodeurl
on the contents before passing it to thelocation
header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.The main method impacted is
res.location()
but this is also called from withinres.redirect()
.Patches
expressjs/express@0867302
expressjs/express@0b74695
An initial fix went out with
[email protected]
, we then patched a feature regression in4.19.1
and added improved handling for the bypass in4.19.2
.Workarounds
The fix for this involves pre-parsing the url string with either
require('node:url').parse
ornew URL
. These are steps you can take on your own before passing the user input string tores.location
orres.redirect
.References
expressjs/express#5539
koajs/koa#1800
https://expressjs.com/en/4x/api.html#res.location
References