-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Clustering module 1.0 deprecations #2306
Conversation
Thank you for contributing to
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
thanks Chris for taking care of this, however i think its best if we wait for the rest of the deep clustering prs to get in and make the deprecating changes here, if thats okay with you |
btw @chrisholder n_clusters and clustering_params are also to deprecate in deep leaening (look at the warning you removed in base class) |
Reference Issues/PRs
#1518
This PR requires PR #2251
What does this implement/fix? Explain your changes.
This PR deprecates all the parameters and models for 1.0 release. Specifically it deprecates the following:
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access