Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Merge MultiRocket and MultiRocketMultivariate #1711

Merged
merged 40 commits into from
Jul 2, 2024
Merged

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Jun 20, 2024

merges the two classes MultiRocket and MultiRocketMultivariate. Part of #1699 fixes #1713

Unlike minirocket, I will keep the transform functions within multirocket separate and raise an issue about how the multivariate version is implemented. I think

  1. it could be made more like the other rockets, but want to get the structure in place first.
  2. there is huge duplication between mini and multi rocket, which can be rationalised at a later date
  3. the random seed is set more often than needs be I think

@TonyBagnall TonyBagnall added the transformations Transformations package label Jun 20, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Jun 20, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)

@TonyBagnall TonyBagnall added the codecov actions Run the codecov action on a PR label Jun 29, 2024
@TonyBagnall TonyBagnall marked this pull request as ready for review June 29, 2024 13:06
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, just got a question about methods (such as fit biases) that are still split between uni and multivariate, what is the reason exactly ?

Couldn't you just use the same method and affect channel_indices to channel 0 and/or num_channels_per_combination=1 for all kernels in the univariate case ?

@TonyBagnall
Copy link
Contributor Author

Overall looking good, just got a question about methods (such as fit biases) that are still split between uni and multivariate, what is the reason exactly ?

Couldn't you just use the same method and affect channel_indices to channel 0 and/or num_channels_per_combination=1 for all kernels in the univariate case ?

you maybe could, but I want to do that on a separate PR for this one, I am not convinced as to how the multivariate is handled. See my comment at the top of the PR

@TonyBagnall TonyBagnall requested a review from baraline July 2, 2024 13:10
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering Tony's comment on rationalising common structures between rockets transformers later, I'd say that this PR has served its goal to put base structure in place.

@TonyBagnall
Copy link
Contributor Author

I'll make a rocket related issue

@TonyBagnall TonyBagnall merged commit 25e4303 into main Jul 2, 2024
16 checks passed
@TonyBagnall TonyBagnall deleted the ajb/multirocket branch July 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecov actions Run the codecov action on a PR enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MultiRocket does not accept singular series in transform
2 participants