[ENH] Add AEDRNNClusterer #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hadifawaz1999 Now they are the same :)) |
hadifawaz1999
requested changes
Aug 15, 2024
There was a problem hiding this comment.
- the default for clustering_algorithm should be "deprecated" in the docstring
- the example should not use n_clusters
- the _score function should use self._estimator not self.clusterer
- the test parameters function should set the estimator to DummyClusterer, to make testing fast, and not set the old parameters to be deprecated
…nto aedrnn-clusterer
…nto aedrnn-clusterer
hadifawaz1999
previously approved these changes
Nov 9, 2024
…nto aedrnn-clusterer
hadifawaz1999
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Clusterer based on Dilated Recurrent Neural Network (DRNN).