Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Remove legacy testing #2076

Merged
merged 4 commits into from
Sep 21, 2024
Merged

[MNT] Remove legacy testing #2076

merged 4 commits into from
Sep 21, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Sep 19, 2024

Follows on from #1877 and #2037, part of AEP 05.

  • Removes the old class based testing framework and scenario files
  • Removes the current test_all_* files for anomaly detection, segmentation, transformers and early classification.
  • Replaces them with a yield function in the new testing framework.
  • Renames test_config.py to testing_config.py because test_ files generally contain test functions which the config does not.
  • Moves some of the soft dependency tests into the new framework. Non-estimator tests remain.
  • Adds a bunch of new classifiers to the exclusion list.

@MatthewMiddlehurst MatthewMiddlehurst added maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request labels Sep 19, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as draft September 19, 2024 13:42
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as draft September 19, 2024 13:42
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review September 19, 2024 18:44
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SebastianSchmidl SebastianSchmidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not go through the individual changes or checked if the checks all make sense, but the new structure is good and makes sense.

@MatthewMiddlehurst MatthewMiddlehurst merged commit f293e9a into main Sep 21, 2024
14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/testing branch September 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants