-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented CBLOF for Anomaly Detection #2243
Conversation
Thank you for contributing to
|
840999b
to
985437b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍🏼
Because CBLOF uses a clustering estimator internally, I would like to see an additional test that passing a custom estimator instance also works.
Do you think that it makes sense to also test with a time series clusterer from aeon? IMO, we use the sliding window approach to transform the time series into another space, where traditional metrics can be used. So, using TimeSeriesKMeans
might not benefit the approach 🤷🏼
@CodeLionX
Okay, will add a test that uses another estimator.
I think we can add a test to check if |
@CodeLionX
|
In this case, I would just state in the documentation that aeon estimators are not supported. It does not make much sense to use them anyway. |
thanks for the contribution |
Reference Issues/PRs
Fixes #2110
What does this implement/fix? Explain your changes.
Implements CBLOF for Anomaly Detection
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access