Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deal with a few warnings #2285

Merged
merged 2 commits into from
Nov 4, 2024
Merged

[BUG] Deal with a few warnings #2285

merged 2 commits into from
Nov 4, 2024

Conversation

TonyBagnall
Copy link
Contributor

No description provided.

@TonyBagnall TonyBagnall added the bug Something isn't working label Oct 31, 2024
@aeon-actions-bot aeon-actions-bot bot added datasets Datasets and data loaders enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request labels Oct 31, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#0B1D38}{\textsf{datasets}}$, $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look innocuous, but it is difficult to tell what is changing/being resolved without the accompanying warnings.

@MatthewMiddlehurst MatthewMiddlehurst removed the enhancement New feature, improvement request or other non-bug code enhancement label Nov 4, 2024
@MatthewMiddlehurst MatthewMiddlehurst changed the title [ENH] Deal with a few warnings [BUG] Deal with a few warnings Nov 4, 2024
@TonyBagnall
Copy link
Contributor Author

These look innocuous, but it is difficult to tell what is changing/being resolved without the accompanying warnings.

tests pass, changes produce same output, tested it offline

@TonyBagnall TonyBagnall merged commit c335673 into main Nov 4, 2024
16 checks passed
@TonyBagnall TonyBagnall deleted the ajb/warnings branch November 4, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datasets Datasets and data loaders testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants