Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG[ Use clone estimator in BaseDeepClusterer to fix check_fit_updates_state fail #2309

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

hadifawaz1999
Copy link
Member

@hadifawaz1999 hadifawaz1999 commented Nov 5, 2024

Fixes #2294
Part of #2230

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working clustering Clustering package testing Testing related issue or pull request labels Nov 5, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#4011F3}{\textsf{clustering}}$, $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@hadifawaz1999 hadifawaz1999 changed the title [BUG[ Use clone estimator in BaseDeepClusterer [BUG[ Use clone estimator in BaseDeepClusterer to fix check_fit_updates_state fail Nov 5, 2024
@hadifawaz1999 hadifawaz1999 marked this pull request as ready for review November 5, 2024 20:24
@hadifawaz1999 hadifawaz1999 requested review from MatthewMiddlehurst and removed request for chrisholder and TonyBagnall November 5, 2024 20:24
@hadifawaz1999 hadifawaz1999 merged commit b27858c into main Nov 6, 2024
15 checks passed
@hadifawaz1999 hadifawaz1999 deleted the aif/fix-aefcn-check-fit branch November 6, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clustering Clustering package testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MNT] Find out why AEFCNClusterer and AResNetClusterer are failing the check_fit_updates_state test
2 participants