-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Improve multithreading testing #2317
Conversation
Thank you for contributing to
|
BaseCollectionEstimator
multithreading handling and improve multithreading testingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not checked if you got all the estimators to set their tag "capability:multithreading"
, otherwise looks good 👍🏼
Maybe we can add an option to the aeon actions bot to run these tests on a PR? |
That is the plan eventually. Yeah, this would fail on more than just the anomaly detectors currently, but similar to the type checking stuff It is more about making the framework available for when someone is a bit more motivated to tackle multithreading. The main stuff I wanted to make sure is tested right now are the parameters and tags so we don't have to do a massive refactor down the line if anyone does ever take it on 🙂. Getting rid of that one commented out test is also a nice bonus. |
Yes, not of high priority, and this already improves consistency considerably! 👍🏼 I'd like to see some way to track the progress and open issues for this topic. I did not locate an issue tracking the work for improving the multithreading. Maybe, you could create an issue and add the already identified issues there? This also seems related: #1886 |
Yep no problem I can create an issue for this. #1886 is more surrounding these lines IMO (https://github.com/aeon-toolkit/aeon/blob/main/aeon/base/_base_collection.py#L92) which is definitely related but good as its own issue |
Adds tests for multithreading and
n_jobs
the test which runs multithreaded estimators is not enabled anywhere currently. Adds tags and changes defaults in a bunch of estimators.