Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Collection and series base tidy #2352

Merged
merged 14 commits into from
Nov 22, 2024
Merged

[ENH] Collection and series base tidy #2352

merged 14 commits into from
Nov 22, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

  • makes __init__ abstracts for the classes in base
  • renames the base series data arrays to contain series in the var name
  • check for soft dependencies in BaseAeonEstimator rather than in the base classes below
  • remove self.fit_time_ from some collection estimators and the collection base. This was not very consistently used.
  • tidy up docs a bit

@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Nov 14, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
This PR changes too many different packages (>3) for automatic addition of labels, please manually add package labels if relevant.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

# Conflicts:
#	aeon/testing/estimator_checking/_yield_anomaly_detection_checks.py
TonyBagnall
TonyBagnall previously approved these changes Nov 22, 2024
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing tests?

@TonyBagnall TonyBagnall self-requested a review November 22, 2024 17:01
chrisholder
chrisholder previously approved these changes Nov 22, 2024
# Conflicts:
#	aeon/base/_base_collection.py
@chrisholder chrisholder merged commit 23f3f0b into main Nov 22, 2024
15 checks passed
@chrisholder chrisholder deleted the mm/estimator-bases branch November 22, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants