Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Add/rework transformation tests and remove from exclude list #2360

Merged
merged 16 commits into from
Nov 24, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Nov 15, 2024

Reworks the tests for transformers a bit, adds some basic checks for tags and output. Removes transformers and some others from the exclude list.

@MatthewMiddlehurst MatthewMiddlehurst added maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request labels Nov 15, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Nov 15, 2024

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$, $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst changed the title [MNT] Remve some excluded tests [MNT] Remove some excluded tests Nov 18, 2024
@aeon-actions-bot aeon-actions-bot bot added full pytest actions Run the full pytest suite on a PR codecov actions Run the codecov action on a PR labels Nov 19, 2024
@MatthewMiddlehurst MatthewMiddlehurst added the transformations Transformations package label Nov 19, 2024
@MatthewMiddlehurst MatthewMiddlehurst changed the title [MNT] Remove some excluded tests [MNT] Add/rework transformation tests and remove from exclude list Nov 19, 2024
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review November 19, 2024 20:38
Copy link
Member

@baraline baraline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but this comment, tested on aeon 0.11.1 and not on main though, did we make a change to RIST in the meantime ?

chrisholder
chrisholder previously approved these changes Nov 22, 2024
# Conflicts:
#	aeon/testing/estimator_checking/_yield_estimator_checks.py
#	aeon/testing/testing_config.py
@MatthewMiddlehurst MatthewMiddlehurst merged commit 05097f5 into main Nov 24, 2024
20 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/excluded-tests branch November 24, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codecov actions Run the codecov action on a PR full pytest actions Run the full pytest suite on a PR maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants