-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Replace prts
metrics
#2400
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these functions look like they should be private/protected. In the tests please run both the new and current functions to ensure the output is the same (using pytest)
aeon/benchmarking/metrics/anomaly_detection/tests/test_metrics.py
Outdated
Show resolved
Hide resolved
Changes made from the previous commit:
|
@MatthewMiddlehurst Please let me know if the test cases are fine, I can separate them into different functions if necessary. |
thanks for this, its really helpful. We will look again next week |
Reference Issues/PRs
Addresses #2066
What does this implement/fix? Explain your changes.
Implementation of Precision, Recall and F1-score metrics.
PR checklist
For all contributions