-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add sphinx event to add capability table to estimators' docs individually #2468
base: main
Are you sure you want to change the base?
Conversation
- add `html-page-context` callback event to add capabilities table individually to each estimators' docs
Thank you for contributing to
|
@all-contributors please add @inclinedadarsh for code |
I've put up a pull request to add @inclinedadarsh! 🎉 |
Seems like the issue was about commit from your side somehow, as merging main fixed it. One last bit that we should resolve is to have uniform format between what your script generate and the format in the files where capabilities are already listed. I think the simplest would be to remove the existing ones and only keep those generated by the script. Would that be OK for you @SebastianSchmidl ? |
Sure, the more automation the better 👍 |
This sounds good. Should I remove all the capabilities table from AD modules that were added manually @baraline ? |
Yes please :) |
Some information in the manually added AD tables is not captured via tags, e.g. * - Input data format
- univariate
* - Output data format
- anomaly scores ◀️ **not in tags**
* - Learning Type
- unsupervised ◀️ **not in tags** I think, we should move this information to the tags then. We just do not have a standard way to do this currently. I would propose the following:
E.g. for DWT-MLEAD: _tags = {
"capability:univariate": True,
"capability:multivariate": False,
"capability:missing_values": False,
"capability:unsupervised": True,
"capability:semi-supervised": False,
"capability:supervised": False,
"output_format: "anomaly scores"
} @MatthewMiddlehurst is this compatible with the original design of the tags and the other modules? |
Reference Issues/PRs
Fixes #1430
What does this implement/fix? Explain your changes.
Add
html-page-context
callback event to add capabilities table individually to each estimators' docs_add_estimator_capabilities_table
functionhtml-page-context
sphinx event callbackDoes your contribution introduce a new dependency? If yes, which one?
No, it doesn't.
PR checklist
For all contributions