-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Improved the test coverage of similarity search module #2476
Conversation
Thank you for contributing to
|
@all-contributors please add @lucifer4073 for code |
I couldn't determine any contributions to add, did you specify any contributions? |
Hi @lucifer4073, to be fair with a previous PR, i'm going to make the same comment as I did in #2472: I'm making major modifications to the module in #2473, including a fix (hopefully) for the issue you identified with the extract top k function. I'm gonna make you the same proposition as #2472, which is to close this PR and hold contribution to this module until #2473 is in. After that, you can do a similar contribution for the test coverage of the module, as I'm sure I will not get to 100% on #2473. If you are OK with this I'll tag you in the original issue with the code coverage report so you know on what function you could add tests. |
Enhancement: Expand Test Coverage for Similarity Search Module #2022.
Summary:
This pull request enhances the test coverage for the similarity search module by introducing new test cases and addressing specific functionalities.
Added Test Cases:
_commons.py
Functions:extract_top_k_and_threshold_from_distance_profiles
numba_roll_2D_no_warparound
numba_roll_1D_no_warparound
Query Search:
apply_exclusion
parameter.SeriesSearch:
inverse_distance
parameter.Additional Consideration:
The test for the function
test_SeriesSearch_apply_exclusion
has not been included due to the issues detailed in #2475.References: