Fix broken links #36
Open
Fix broken links #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroggen
reviewed
Dec 6, 2024
| @@ -47,7 +47,7 @@ Aergo also offers a development toolchain that includes package management, `Aer | |||
| Infrastructure | |||
| -------------- | |||
|
|
|||
| Aergo is currently available as a `public testnet <../using-testnet/index.html>`_ and separate private installations. | |||
| Aergo is currently available as a `public testnet <../using-network/connecting.rst#testnet>`_ and separate private installations. | |||
There was a problem hiding this comment.
The correct is https://docs.aergo.io/en/latest/using-network/connecting.html#testnet
html instead of rst
kroggen
reviewed
Dec 6, 2024
| @@ -46,7 +46,7 @@ Generate BP accounts and keys | |||
|
|
|||
| You can use any machine (e.g. your own local machine) for this. | |||
|
|
|||
| Start by installing `aergocli <../tools/aergocli.html>`__ if you haven't already. | |||
| Start by installing `aergocli <../tools/aergocli.rst>`__ if you haven't already. | |||
There was a problem hiding this comment.
Same, and for many other changes on this PR
kroggen
reviewed
Dec 6, 2024
| @@ -4,7 +4,7 @@ Transaction Fees | |||
| The Aergo protocol includes transaction fees that need to be paid | |||
| according to the configuration of the network. | |||
|
|
|||
| Versions prior to 2.0 (`see 1.3 docs <https://docs.aergo.io/en/1.3/specs/fees.html>`_) | |||
| Versions prior to 2.0 (`see 1.3 docs <https://aergo.readthedocs.io/en/1.3/specs/fees.html>`_) | |||
There was a problem hiding this comment.
it should be docs.aergo.io
if the link is not working, then the correct must be found
There was a problem hiding this comment.
It appears that only links to /latest/ are working
Links to direct versions are not working, for some reason
We will need to check that
kroggen
reviewed
Dec 6, 2024
| @@ -56,7 +56,7 @@ Technical details | |||
| ----------------- | |||
|
|
|||
| Names are stored in the state of the special account :code:`aergo.name`. They are created and updated using special governance transactions. | |||
| Refer to `transaction types <transaction-types.html>`_ for the technical specification of these actions. | |||
| Refer to `transaction types <transactions.rst#transaction_types>`_ for the technical specification of these actions. | |||
There was a problem hiding this comment.
It should be /specs/transactions.html#transaction-types
And then there is no need to add a new anchor
kroggen
reviewed
Dec 6, 2024
| @@ -36,6 +36,8 @@ Payload | |||
| A payload can be any kind of binary data, but is most often used with JSON strings for | |||
| `smart contract calls <contracts.html>`__. | |||
|
|
|||
| .. transaction_types: | |||
There was a problem hiding this comment.
As said above, this is not required
kroggen
reviewed
Dec 6, 2024
| @@ -22,7 +22,7 @@ Staking & Voting | |||
| user wanting to vote must stake their tokens since the voting power is | |||
| weighted by the number of staked tokens, as remarked above. | |||
|
|
|||
| All of these requests are performed via a `transaction <./transactions.html#governance-type>`_. | |||
| All of these requests are performed via a `transaction <./transactions.rst#governance_type>`_. | |||
There was a problem hiding this comment.
It should be /specs/transactions.html#governance-type-1
Then there is no need to add new anchor
kroggen
reviewed
Dec 6, 2024
| @@ -47,6 +49,8 @@ Normal type (0) | |||
| Normal transactions are used to transfer tokens and calling smart contracts. | |||
| Since version 2.0, there are more precise transaction types that should be used instead. | |||
|
|
|||
| .. governance_type: | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.